Code Review for Best Practices + Dosing Pump Issue

[GT_Jacket]

Ac Jr w/ DC8 + Lunar module...

Please see my setup below and make any recommendations according to your experiences / best practices. Also, I can't seem to get the dosing pumps to fire properly. I can adjust the OSC times to control the right amount during the day (Calc) and night (Alk) but according to the log for Alk last night - The dummy timer appears to come on and off at the right times but the Alk pump only appears to fire once at 12:03 AM on and off at 12:08am??? I don't have the PH override on the ALK due to using receipe #2 which does not appear to raise PH.

LT1$-A1 // Dusk Dawn Lights
LT2$-A2 // Main Lights
HET^-A3 // Heaters
DPA%-A4 // Dosing Pump (BRS 1.1) for 2-Part Alk
PMP#-A5 // Main Return Pump
ATO%-A6 // ATO
SKM^-A7 // Skimmer
DPC%-A8 // Dosing Pump (BRS 1.1) for 2-Part Calc
MON*-C4 // Moon Lights
DMA#-P1 // Dummy Timer for Alk
DMC#-P2 // Dummy Timer for Calc

// Initialize ports that need it
If Time > 00:00 Then PMP ON
If Time > 00:00 Then SKM ON
If Time > 00:00 Then ATO ON

// Light Schedule
If Time > 11:00 Then LT1 ON
If Time > 21:00 Then LT1 OFF
If Time > 13:00 Then LT2 ON
If Time > 18:00 Then LT2 OFF
If Moon 000/000 Then MON ON

// Temp Schedule (Have the table locked at 79 degrees for all months )
If Temp < RT+-0.1 Then HET ON
If Temp > RT+0.0 Then HET OFF
If Temp < 60.1 Then HET OFF

// Dosing Alk
If Time > 22:00 Then DMA ON
If Time > 08:00 Then DMA OFF
OSC 005/115 ON/OFF Then DPA OFF
If Timer DMA = OFF Then DPA OFF

// Dosing Calc
If Time > 10:00 Then DMC ON
If Time > 20:00 Then DMC OFF
OSC 002/073 ON/OFF Then DPC OFF
If Timer DMC = OFF Then DPC OFF

// Feed and Power Outage
If FeedA 000 Then PMP OFF
If FeedA 030 Then ATO OFF
If FeedA 045 Then SKM OFF
If Power 045 Then SKM OFF
If Power 030 Then ATO OFF

Thanks,
Brett

 

[GT_Jacket]

Help - my Calc dosing pump only ran one of the OSC cycles also today. The dummy timer (DMC) turn on and stayed on properly...

 

[RussM]

I don't recall if an If Time statement will "wrap around" past midnight on a ACjr , but if it doesn't, that could be the problem... it would explain only a single Alk dosing cycle per night.

I could be way off base, but there's no harm in trying this addition:

// Dosing Alk
If Time > 22:00 Then DMA ON
If Time > 00:00 Then DMA ON
If Time > 08:00 Then DMA OFF
OSC 005/115 ON/OFF Then DPA OFF
If Timer DMA = OFF Then DPA OFF

 

[GT_Jacket]

Thanks Russ, but I don't think that is it. The calc is also doing the same. Also, the virtual timers appear to be going on/off correctly.