Most seahorses in the ornamental hobby would have a life expectancy of 7 or 8 years as mentioned, with extremes both shorter and longer.
Reality is that most seahorses sold for the hobby will perish in less than one year.
With education, and more true captive bred livestock becoming available, the odds of success are improving however.