DWZM,
Yes, I meant The Linear Technology - company. I was building DC/DC converters and charger, so it probably does not matter what parts I've used. Nevertheless, I remember they had dedicated Led drivers (chips), though likely all SMD packages. I would look anyway, as they definitely are one of the best analog designers/chip makers in the world, and have very good documentation, and simulator.
With this DIY Led driver, I totally agree that we don't need the absolutely optimal design. Actually it was my point that maybe while designing (with the OnSemi spreadsheet), you should not try to chase the best performance, but a more gentle switching regime, to ensure longer life (and better chance of it working in the first place, which is an achievement in itself with switching regulators... in my experience

). Judging by the fact that it works, and there is no any obvious overheating, you've likely done it well already. In particular, you may do without the second tantalum capacitor, the Stu was referring to, in this application, although I would check the stability of the current on the output using oscilloscope, or simulating this or similar circuit with only one, electrolytic output capacitor. Btw, you really should try the Linear's simulator. It is very simple, useful, and a lot of staff built in, including many designs of switching converters (voltage and current) based on their chips. (hmm, disclaimer: I don't work for Linear, or anywhere near the electronic industry

)
...but, the question of lifespan is still important. I.e., I would not want to build a led rig, with idea it to be maintenance free for 10 years, only to learn that I have to replace all the drivers every 12 months or so.
The only factor, I remember/could think of now, which is important here, given your already working design, is the input and output capacitors. I don't remember now why, but I think the output capacitor was the bottleneck, and you really want to get the best one that fits the design. Again, don't remember now all the details, and don't have time to get into this right now, really sorry (common, just check timestamps of my posts

). Off the top of my head, you need to ensure (1) that capacitor is fine with the operating mode of the switcher (frequency, and RMS of voltage and/or current), (2) its internal resistance is as small as possible (at the operating mode/frequency! - it usually will be different than the one stated in the capacitor's spec). Both of the above will give you the real lifespan of the capacitor. I remember it was all a bit involved, but some manufacturers provided a free design software that gave you the answers, including the lifespan....
Actually just googled one of them: Kemet. They have some program here:
http://www.kemet.com/kemet/web/homepage/kechome.nsf/weben/kemsoft
If it does not give all the answers, or not that friendly try another company (I've used at least two programs from different companies and one of them was very good, one of them was Kemet's - but don't remember which one

)
In my experience, it was very important to select the capacitors right, as their characteristics, and lifespan change a lot depending on mode of operation and other parameters (and to my great surprise to ambient themperature - although it should not be an issue in this particular case)
Nope. No tantalum capacitors. Ceramic for the small stuff an aluminum for the large stuff.
I know it's possible to do better with specs on some of the components I chose (2k hour life caps vs. 10k). ....
Ah, exactly what I was talking about, I would use the 10K capacitor. The lifespan gets reduced exponentially, when the capcitor starts to fail, due to normal aging, or due to dificult working mode.
I know, I write too much, too late, and remember little... hope it helps anyway, or wait another 3-4 months, and I will start MY build
